Open PokezardVGC opened 1 year ago
Duplicate with 110 as both are referring to the lack of alt statements in the sequence diagrams which is recurring across all sequence diagrams.
[The team marked this bug as a duplicate of the following bug]
Edit diagram did not show alt statements in sequence diagram
Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.
![]()
Checking if index and valid person not shown in sequence diagram.
[original: nus-cs2103-AY2223S1/pe-interim#145] [original labels: type.DocumentationBug severity.Low]
[This is the team's response to the above 'original' bug]
Thanks for the bug report, however the purpose of our sequence diagrams are to capture a high level view of the success cases for the commands without going into the low level details of the code. Perhaps this may have been an issue if an activity diagram were used, however in line with our motive to capture the high level overview we did not use such a diagram.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
Reason for disagreement: [replace this with your explanation]
Team chose [response.Rejected
]
Reason for disagreement: [replace this with your explanation]
Likewise in deleteCommand code, there was a check for valid index but not shown in sequence diagram