PolMine / LinkTools

R package with tools for data linkage
GNU General Public License v3.0
0 stars 0 forks source link

The description of the LTDataset class is currently not very clear #15

Open ChristophLeonhardt opened 1 year ago

ChristophLeonhardt commented 1 year ago

The description states that the class "facilitates the linkage of datasets via shared unique identifiers". However, the class enriches data via shared attributes (i.e. metadata / variables) and the mechanism can be used to add unique identifiers. The entire documentation is very focussed on the addition of these IDs, but other data could be added, too. This should be made more clear.

Also, the first step described in the documentation of the class is described as

a) the preparation of datasets which should be linked, i.e. the transformation into a comparable format and the assignment of shared unique identifiers

This step currently is done in advance. Here, a decision should be made where this should be done. The class is probably not the place to do this transformation.

https://github.com/PolMine/LinkTools/blob/60543c9a433a5ff33f1dffaf3d719f4f501d89b5/R/LTDataset.R#L1-L8