PolMine / LinkTools

R package with tools for data linkage
GNU General Public License v3.0
0 stars 0 forks source link

Should it be possible to add new values to exisiting s-attributes? #16

Open ChristophLeonhardt opened 1 year ago

ChristophLeonhardt commented 1 year ago

There might be a use case to add new values to an existing s-attribute, for example if new data emerges (updates on Wikidata, etc.). Currently, there is a check which checks if the attribute to be added is already in the corpus.

https://github.com/PolMine/LinkTools/blob/60543c9a433a5ff33f1dffaf3d719f4f501d89b5/R/LTDataset.R#L217-L219

It probably should be possible to add values to an existing structural attribute. But aside from the technical implementation this also becomes a question of how to document these changes to the corpus. It could be rather confusing if two versions of the same corpus with the same build date and version have different values in the same structural attribute. This should be avoided.