I think that the second call is not up-to-date: wouldn't the argument threads be an integer instead of boolean? This is what the rest of the documentation explicitly states.
I am not sure how these two calls of the same function would differ. If the second call should showcase the threads argument, then this could be explained.
Another minor remark would be that in the documentation for "Scenario 2b" it is necessary to instantiate the Pipe object. This is done in "Scenario 2a" but if it should be possible to run the examples independently, the object is missing. It might be redundant, but I think it would be clearer if the Pipe object is instantiated in "Scenario 2b" as well.
The documentation of
corenlp_annotate()includes two consecutive calls of the function:https://github.com/PolMine/bignlp/blob/e6a6bda102d338880be787caf53b1f03a728600a/R/corenlp.R#L52-L65
Two remarks here:
threadsbe an integer instead of boolean? This is what the rest of the documentation explicitly states.threadsargument, then this could be explained.Another minor remark would be that in the documentation for "Scenario 2b" it is necessary to instantiate the Pipe object. This is done in "Scenario 2a" but if it should be possible to run the examples independently, the object is missing. It might be redundant, but I think it would be clearer if the Pipe object is instantiated in "Scenario 2b" as well.