search

PolMine / polmineR

R-package for text mining with the Corpus Workbench (CWB) as backend
49 stars 9 forks source link

Adapt to changes in markdown >= v1.3 #235

Closed yihui closed 1 year ago

yihui commented 1 year ago

Hi @ablaette, I've submitted two PRs and I'm not sure if you have noticed them:

I'd truly appreciate it if you could merge them and make a CRAN release at some point. That will give me a little more freedom in making changes in the markdown package in the future. Thanks!

ablaette commented 1 year ago

Fixed. Many thanks for the PR - and my apologies for taking so long to incorporate this solution. I will submit to CRAN soon!

yihui commented 1 year ago

Thank you so much! No need to apologize! I understand that you must have been going through some difficulties.

I feel the tests under https://github.com/PolMine/polmineR/tree/master/inst/fulltext may be too strict, e.g., they are sensitive to changes in white spaces or line breaks, which can prevent me from making such trivial changes in the markdown package. I don't know how to improve the tests, but one way to give me a little more freedom is to conditionally run the tests, e.g., on Github Actions only and not on CRAN (skip_on_cran()). Would that be okay to you?

ablaette commented 1 year ago

skip_on_cran() is a very reasonable suggestion, I just implemented that. Thanks a lot for your support, understanding and guidance - and for your great work!

yihui commented 1 year ago

Perfect! Please feel free to let me know if I break your tests with critical changes in markdown in future, and I'll be happy to help. Thanks again!