PolarGeospatialCenter / imagery_utils

Other
34 stars 10 forks source link

Pansharpened mosaic selection #88

Closed bakkerbakker closed 3 days ago

bakkerbakker commented 2 months ago

Adding functionality to get mul-pan pairs in the mosaic query script using the --require-pan flag.

bakkerbakker commented 2 months ago

We will have to check pgc_mosaic.py to make see if we need to port any of the functionality over there and then add a pansharpening option to image-mosaic-scripts for batch processing.

bakkerbakker commented 1 month ago

With the addition in the commit here, the batch processing scripts in image-mosaic-scrips should work as long as the config includes the pansharpen flag. Once QC is complete, we can test the mosaic part of the process, but I don't think this branch will need any more additions. Will leave in draft form until then.

Also, including a bug fix for multi-task pansharpen jobs that used the --resolution flag that recursively made the output resolution larger when submitting multiple tasks within the same slurm job.

bakkerbakker commented 1 month ago

Corresponds to changes made to image-mosaic-scripts in the PR here: https://github.umn.edu/pgc/image-mosaic-scripts/pull/7

clairecporter commented 1 month ago

Did you run the test suit to make sure these changes did not break something else? In the same vein, can you add a test to run through this functionality? Let me know if there's a blocker I can help with on that.

bakkerbakker commented 5 days ago

@clairecporter I've run these changes through the full mosaic production process but I have not run the tests or updated the test suite. I'll probably need a little help adding unit tests for this update.

clairecporter commented 5 days ago

The mosaic test are not yet repaired. Do you want to wait until I get them fixed up?

clairecporter commented 3 days ago

With these commits, all the tests work. Some are skipped for the moment, but we'll revisit those when we switch to pytest. If you approve of the changes, you can roll these into main.