search

PolarNotion / turntable

A Responsive JQuery Slider
http://polarnotion.github.io/turntable/
515 stars 48 forks source link

Problem using turntable with xhtml #10

Closed elEglon closed 8 years ago

elEglon commented 8 years ago

Dear reader/s, Using html-docs turntable works as desired. Trying to embed it into a xhtml-doc (needed for an eBook) it doesn't work any longer. Any ideas are welcome. Thank You and best wishes Eglon

Johnrae commented 8 years ago

Hey elEglon, Thanks for letting us know! I'm not sure how many eBook clients support javascript like this, but if you need to convert the plugin to create valid xhtml or xml tags, I have a quick fix for you.

So I believe the issue is the plugin will append an image tag to your list, but its not self closing and not valid xhtml. If you grab the un-minified file and add a "/" on line 66 like so: This $(this).html('<img src="' + $(this).data("imgSrc") + '">'); Should be $(this).html('<img src="' + $(this).data("imgSrc") + '"/>');

Hope this helps!

elEglon commented 8 years ago

Hi John, Thank you for your info. I talked to Morgan and we were able to solve the problem. The fix you mention is working fine! Best wishes Eglon