search

PolarisSS13 / Polaris

Polaris - A version of Spacestation13, forked from Baystation12.
https://ss13polaris.com/
Other
71 stars 305 forks source link

Can't use items on surgery patient on help intent #1849

Closed ItsAnJonth closed 7 years ago

ItsAnJonth commented 8 years ago

Brief description of the issue

Related to #1687 You cannot use items when someone is on a table when using help intent. Other intents work fine. Despite the comment stating that you only get the message but it works, it does not work.

What you expected to happen

Syringes, health scanners, etc. work

What actually happened

Nope.

Steps to reproduce

Put someone on a surgical table. Try to inject on help. Then try on a different intent.

Additional info:

Yoshax commented 8 years ago

I think this is more related to the attack call cleanup, it's likely the surgery thing is being called before the attack.

mwerezak commented 8 years ago

do_surgery() should become an /obj/item proc, I think that would be the best way to resolve this.

Yoshax commented 8 years ago

@mwerezak does the same happen on Bay, or has it been resolved there, or perhaps never happen?

Techhead0 commented 8 years ago

As of Monday on the Baystation server: Health scanners currently refuse to work and give the error message, if the patient is buckled to a roller bed and you are on help intent. I think that confirms the bug exists on Bay. There might also be an open issue somewhere. EDIT: https://github.com/Baystation12/Baystation12/issues/11881 was fixed by https://github.com/Baystation12/Baystation12/pull/11934, but that change was reverted by https://github.com/Baystation12/Baystation12/pull/13122 EDIT 2: A direct consequence #1687 on Polaris. The PR description even says so.

This will however make it so you can't use items on someone who on the table while on help intent, such as health analysers or such. Such is life.

Yoshax commented 8 years ago

Ah, yes. But at the time, I was wrong. Before the port of the attack call stuff the action of using the item, you both scanned the person and got the message.

ItsAnJonth commented 8 years ago

This still seems to be occurring.

Yoshax commented 8 years ago

With what items?

ItsAnJonth commented 8 years ago

Trauma kit, most likely because it's also used for a surgery, but also it seems FBP surgery is repeatedly saying things cannot be used or otherwise not working as intended, which may or may not be related. I need replicate the exact details.

Atermonera commented 7 years ago

Not recently observed, should be closeable