PolarisSS13 / Polaris

Polaris - A version of Spacestation13, forked from Baystation12.
https://ss13polaris.com/
Other
71 stars 305 forks source link

POI - 'Demonpool' Remap #9279

Closed ephemeralstoryteller closed 10 months ago

ephemeralstoryteller commented 11 months ago

Adds a somewhat crude, generic version of mining's random crates that don't draw from the random loot pool, for use in PoIs. Remaps the Demonpool.

The 'demonpool' PoI (the one with all the bats/the cult one) is an interesting take on a more anomalous location where creatures from a hostile otherworld have poured into our reality, though suffers from being cluttered and spilling a ton hostile mobs into the SAR a little too easily.

Before 2023-10-30 18 12 16

After 2023-11-03 16 59 10

Bigger critters:

bigblob bigshade

ephemeralstoryteller commented 10 months ago

will do! would it be preferable to come up with a working solution 'til I can refactor? I'm going to have to learn how to do that which might be a bit, I'm not super Byond savvy yet

Atermonera commented 10 months ago

It's should basically amount to...

  1. Replacing /obj/structure/closet/crate/secure/POI with /obj/structure/closet/crate/secure/decalock in your changes.
  2. Renaming /obj/structure/closet/crate/secure/loot to .../decalock/loot.
  3. Cutting all the copy/pasted code from the new subtype.
  4. Updating that loot path in the other places in code where it's referenced.

I'm inclined to demand them here, because promises of followup PRs are... not uncommonly broken.

ephemeralstoryteller commented 10 months ago

gotcha! okay, will do, thank you

ephemeralstoryteller commented 10 months ago

Should have a new commit today, just need to test more. So far, working as intended with suggested changes