search

PoliNetworkOrg / WiFiLinux

2 stars 3 forks source link

Subject field parsing behaves incorrectly when fields contain commas #2

Closed cristianfalvo closed 2 years ago

cristianfalvo commented 2 years ago

Subject fields extracted from the certificate are not parsed correctly by the regex in __process_p12 when they contain commas; for instance, the field

"street = "Piazza Leonardo da Vinci, 32"

is parsed as two fields,

'"street = "Piazza Leonardo da Vinci', '32"'

pbn98 commented 2 years ago

Thank you, I'll fix that asap

pbn98 commented 2 years ago

I can't find it, could you please tell me the line number?

cristianfalvo commented 2 years ago

I can't find it, could you please tell me the line number?

Should be the regex at line 540

pbn98 commented 2 years ago

I'm not familiar with that kind of stuff, would you mind fixing it and making a pull request?

cristianfalvo commented 2 years ago

I have a sort of patch for the problem, but it's far from elegant and I cannot guarantee it works with all cases, but it should work

github-actions[bot] commented 2 years ago

Stale issue message