Closed Naeemkh closed 1 year ago
Please choose a naming convention and use it throughout the codebase, for example the following function and class names are not consistent with the code.
_prepareRows
On_off_reduction_matrix
This issue is related to this submission: https://github.com/openjournals/joss-reviews/issues/5019
This issue remains unresolved; however, I will close it for now. Please keep it in mind for consideration during any future refactoring efforts.
Please choose a naming convention and use it throughout the codebase, for example the following function and class names are not consistent with the code.
_prepareRows
in the following line: https://github.com/PoliUniLu/cora/blob/6efe5ca630c53f5e2bc2b9f339b5118b5a361da9/cora/prime_implicants.py#L630On_off_reduction_matrix
in this line: https://github.com/PoliUniLu/cora/blob/6efe5ca630c53f5e2bc2b9f339b5118b5a361da9/cora/on_off_alg.py#L80This issue is related to this submission: https://github.com/openjournals/joss-reviews/issues/5019