misc cleanup for automatic-archives

Police-Data-Accessibility-Project / automatic-archives

MIT License

1 stars 1 forks source link

misc cleanup for automatic-archives #18

Open josh-chamberlain opened 1 month ago

josh-chamberlain commented 1 month ago

Context

The main contributor for this project couldn't continue, so we left a few things unpolished.

Requirements

[x] we're using the PDAP API, SPN API, and last_cached and url_status properties in the database to track this, but we need to update the readme to reflect all that
[x] the github action isn't working at the moment
[ ] I think we should change the word "cache" to "archive" throughout

Docs

[ ] changing the name of a property in the db affects data dictionary and the README

josh-chamberlain commented 1 month ago

fixed first task in #17

maxachis commented 4 weeks ago

@josh-chamberlain On it! I will need two environment keys. They're not described in the README, so I'm lacking some context.

VITE_VUE_APP_BASE_URL VUE_APP_PDAP_API_KEY

maxachis commented 4 weeks ago

[ ] I think we should change the word "cache" to "archive" throughout

Note to myself (mostly): This will require changes to the database and presumably endpoints touching it as well, which will require some PRs outside of this project.

josh-chamberlain commented 3 weeks ago

@maxachis those are both org-level secrets, they're used by data-sources-app as well

maxachis commented 3 weeks ago

@josh-chamberlain Got it. I could probably benefit from receiving them privately, just so I can test the functionality.