Open maxachis opened 1 month ago
@maxachis I'd say the app doesn't need to function appropriately without environment variables; we could just throw an error and tell people they're required.
@maxachis I'd say the app doesn't need to function appropriately without environment variables; we could just throw an error and tell people they're required.
@josh-chamberlain Oh, of course: What I meant was it we should test that it functions appropriately by throwing and error and telling people they're required.
There are several cases where an environmental variable is pulled but where no clear error is thrown when the environmental variable is not provided.
For example,
login_queries.py
:This can cause confusion, especially for developers, who will have to dig into the code to find out that the cause of an error is a missing environmental variable.
Tests should additionally be added to ensure the app functions appropriately when environmental variables are not provided.