Deprecate regular_api_checks.py

[EvilDrPurple]

Fixes

• 323

Description

• Deletes the files regular_api_checks.py and tests.yml
• Old code that was commented out in app_test.py that referenced the VUE_APP_PDAP_API_KEY is removed

Testing

• Should be no functional changes to the code, all items removed were non-functional

Docs

• A line referencing regular_api_checks.py was removed from the README.md

[EvilDrPurple]

@maxachis ohh okay gotcha. Is that just where all new PRs should go? And did you want me to fix it or were you going to handle it?

[maxachis]

@maxachis ohh okay gotcha. Is that just where all new PRs should go? And did you want me to fix it or were you going to handle it?

@EvilDrPurple To be honest I forgot that I could handle someone else's PR 😅. I say do it yourself this time just to familiarize yourself with it. And yeah, unless otherwise specified (or @josh-chamberlain contradicts me), new developments should go into the dev branch of the v2 repository, where they will eventually be merged into the main of the v2 repository (not the main of the v1 repository).

You will have to close this PR and re-open it a second time, being careful to specify the correct repository as well as the branch.

[josh-chamberlain]

@EvilDrPurple yeah, sorry I didn't mention that! At the moment we should be making changes in the v2 fork unless we need to fix something for people actively using v1.