Create `locality` table - Githubissues

Police-Data-Accessibility-Project / data-sources-app

An API and UI for using and maintaining the Data Sources database

MIT License

4 stars 5 forks source link

Create `locality` table #448

Closed maxachis closed 2 months ago

maxachis commented 2 months ago

Context

Currently, information about localities is constrained to the agencies table
I ran the numbers on how many distinct rows we have in agencies versus how many distinct county_fips/state_iso/municipality combinations, and came to:
- 23448 agencies
- 13656 distinct county_fips, state_iso, municipality combinations
Normalization would help simplify this situation and reduce the amount of redundant data present.

Requirements

Create new locality table
Update agencies logic so that, when an agency has a locality not yet present in the localities table, that locality is added, and the reference updated.
Update variable column permissions logic for agencies to account for the change in column nomenclature.

Tests

Add tests that, when a new locality is added, it properly populates the localities table, and a foreign key to that entry exists in the relevant agencies row

Docs

Ensure that agencies column permission table is properly updated

Open questions

None at this time.

maxachis commented 2 months ago

Closed in favor of #450