Police-Data-Accessibility-Project / data-sources-app

An API and UI for using and maintaining the Data Sources database
MIT License
2 stars 5 forks source link

Revise `agency_source_link` and remove `agencies.data_sources` #457

Open maxachis opened 1 week ago

maxachis commented 1 week ago

Context

Requirements

Follow-up:

Tests

Docs

Open questions

josh-chamberlain commented 1 week ago

agencies.data_sources is one of those magic multi-reference fields in Airtable, and it strikes me as possible that the agency_source_link table was built that way. Is the idea to build the link table instead by checking each source for its agencies? If so...I approve

maxachis commented 1 week ago

@josh-chamberlain I'm also planning to remove the other column that reference these, such as data_sources_last_updated and data_sources_count (which are stale, anyway).

I'll also note that this breaks /homepage-search-cache, so I'm commenting out that endpoint and its tests and creating a new issue for fixing that (if we want to):