search

Police-Data-Accessibility-Project / data-sources-app

An API and UI for using and maintaining the Data Sources database
MIT License
4 stars 5 forks source link

Fix or remove `/homepage-search-cache` #458

Open maxachis opened 1 month ago

maxachis commented 1 month ago

/homepage-search-cache was broken by changes to the agencies table which removed columns referencing data sources.

However, /homepage-search-cache is also 1) Only for internal use 2) Not seemingly in active use 3) Still available in production

So we have a moment to consider whether we still want this endpoint and its attendant functionality, or if we'd just like to get rid of it completely

josh-chamberlain commented 1 month ago

I do not remember offhand which of our services was supposed to use this endpoint, do you?

Related: https://github.com/Police-Data-Accessibility-Project/data-sources-app/issues/428

maxachis commented 1 month ago

I do not remember offhand which of our services was supposed to use this endpoint, do you?

Related: #428

@josh-chamberlain This was part of one of the data requests I'd worked on early in my contracting days, where we were trying to solve for agencies that didn't have homepage urls in our database. I developed the /homepage-search-cache as a way to cache the results of those searches so we didn't repeat them multiple times. However, it seems we performed searches for most of the outstanding agencies (although we may come across more in the future).

josh-chamberlain commented 1 month ago

@maxachis It's your call, but I suspect it's worth just rethinking that entirely if we need it again, given how much learning has taken place in the past few months.