Police-Data-Accessibility-Project / data-sources-app

An API and UI for using and maintaining the Data Sources database
MIT License
4 stars 5 forks source link

Automate `data_sources.last_approval_editor` logic to be automatically generated #499

Open maxachis opened 2 weeks ago

maxachis commented 2 weeks ago

Context

Requirements

Tests

Docs

Open questions

josh-chamberlain commented 1 week ago

@maxachis yes, fantastic catch. this is sort of a part of #32, because it's a field that is automatically updated by Airtable—but it need not be manual in v2.

maxachis commented 1 week ago

@josh-chamberlain With this, I want to get some clarification:

  1. Do we expect anyone aside from admins to be able to modify these data sources?
  2. Do we want to record solely who changed approval status, or who modified any value, or both separately?
josh-chamberlain commented 4 days ago

@maxachis

  1. maybe eventually, but not right now
  2. last_approval_editor should be only related to approval status. full edit history might happen in #477
maxachis commented 1 day ago

@josh-chamberlain For the moment, I intend to convert the existing last_approval_editor column to last_approval_editor_old for posterity. However, I can remove it entirely, as you desire.