Police-Data-Accessibility-Project / data-sources-app

An API and UI for using and maintaining the Data Sources database
MIT License
4 stars 5 forks source link

Set `external_accounts` foreign key to users to be `ON DELETE CASCADE` #506

Open maxachis opened 2 weeks ago

maxachis commented 2 weeks ago

Context

Requirements

Tests

Docs

Open questions

maxachis commented 1 week ago

Currently made a minor adjustment to the dev_script to enable this, and pushed it directly to main. Not the most kosher, but figured I could get away with it since it's so minor, and can easily revoke it otherwise. Won't be able to do that in the future, but since it's still in dev, weeeee!

We'll see how it turns out tomorrow on the regular update.

josh-chamberlain commented 1 week ago

@maxachis I feel a duty to follow up—how did this turn out?

maxachis commented 1 week ago

@maxachis I feel a duty to follow up—how did this turn out?

Totally fine! Everything subsequently passed without issue!