Police-Data-Accessibility-Project / data-sources-app

An API and UI for using and maintaining the Data Sources database
MIT License
4 stars 5 forks source link

Create `/map` namespace and move `/data-sources-map` to there #521

Closed maxachis closed 2 weeks ago

maxachis commented 2 weeks ago

Context

Currently, the data-sources/data-sources-map endpoint is online, but there are a few issues:

  1. The /data-sources/data-sources-map endpoint overlaps with the /data-sources/{resource_id} endpoints, which may not be best practice
  2. The endpoint requires API or JWT key authorization, but this is not displaying in the API documentation, possibly because of 2.
  3. Describing it as "data sources" is somewhat misleading, because the data is a product of both data sources and agencies (specifically, it provides the data sources associated with agencies which themselves have non-null latitude and longitude

Requirements

Tests

Docs

Open questions

maxachis commented 2 weeks ago

Eh, never mind, not a big enough deal once I figured out the bug