Police-Data-Accessibility-Project / data-sources-app

An API and UI for using and maintaining the Data Sources database
MIT License
4 stars 5 forks source link

Consider upgrading python version #531

Open maxachis opened 1 week ago

maxachis commented 1 week ago

Context

Upgrading to a newer Python version such as 3.12 or 3.13 can provide us with performance improvements and increased quality-of-life features, provided it doesn't break anything.

Requirements

Tests

Docs

Open questions

maxachis commented 4 days ago

PR set up here:

https://github.com/Police-Data-Accessibility-Project/data-sources-app-v2/pull/191

Tests are all passing (after I made some adjustments), but I've not yet merged because I want to confirm with @joshuagraber and @josh-chamberlain that this is kosher.

Additionally, beyond this, we'll need to check that things function as expected in data-sources-v2.pdap.dev -- just because everything works in Github Actions does not guarantee that it'll play nice with things like the Digital Ocean Python Buildpack (though it's certainly promising).

If we want to be extra wippy-dippy safe, we could modify the Digital Ocean spec for pdap.dev to pull from the PR'd branch temporarily, or simply merge into dev and rollback if it turns out not to work.

maxachis commented 4 days ago

Success! I tried dev right now, and it seems to be working 😎