search

Police-Data-Accessibility-Project / design-system

Vue component library and assets for PDAP-branded client apps
MIT License
0 stars 0 forks source link

feature(tailwind): Use tailwindcss #10

Closed joshuagraber closed 8 months ago

joshuagraber commented 9 months ago

Resolves #9, resolves #4

To test

  1. Run npm run build Open demo.html with live server, compare with pdap.io, note any differences in styling
  2. Run npm link
  3. In another local repository (pdap.io or data-sources-app would work), run npm link pdap-design-system and npm run build
  4. You should now have a symlink to the local package (since this update has not yet been published).
  5. From the root directory of the installing project, run pdap-design-system --copy-assets --to=test-directory and ensure that the assets are copied over to a dir called /test-directory in the root of the project.
  6. Revert changes from steps 3-5 (These styles will be implemented in other projects once this update is published).
josh-chamberlain commented 9 months ago

I usually leave comments when I see stuff in my github notifications, but I see this is a draft. Not getting into it deeper yet, but thanks for publishing!

joshuagraber commented 8 months ago

cc @josh-chamberlain @mbodeantor @kalenluciano 👀 This one is ready for review. Quite a big PR, but it forms the foundation for the component library, etc., that we want to build on top of this.

josh-chamberlain commented 8 months ago

Nice! Based on "note any differences in styling" it seems like you're expecting there to be differences in appearance, right? Lot of little changes from the old demo.html to the new one. Or, maybe I didn't run it properly. Clearly you've considered and put in the readme instructions for how people should implement this across projects which is good, and the "To test" part of this PR worked for me.

For my part of the review I will need some time to talk this through, ask basic questions, and make sure I understand. Maybe we could all talk sometime soon just to get on the same page, as this is so foundational.

josh-chamberlain commented 8 months ago

Removing my request for review because this passes my tests. Leaving it up to Marty (w/ Kalen's feedback)