search

Police-Data-Accessibility-Project / design-system

Vue component library and assets for PDAP-branded client apps
MIT License
0 stars 0 forks source link

refactor: 2023 launch aesthetic tweaks #30

Closed josh-chamberlain closed 6 months ago

josh-chamberlain commented 7 months ago

fixes #36

should be followed by https://github.com/Police-Data-Accessibility-Project/data-sources-app/issues/130

josh-chamberlain commented 6 months ago

@joshuagraber this is about ready to be reviewed, then applied to data-sources-app dev and pdap.io dev. Most (if not all) remaining changes will be made to classes in data-sources-app.

joshuagraber commented 6 months ago

this is about ready to be reviewed

Nice @josh-chamberlain! I also have some minor misc cleanup (docs, comments, etc.) I'd like to get in, are you good if I push those to this branch once you're ready?

josh-chamberlain commented 6 months ago

@joshuagraber sure thing! I will still rewrite the commits if you don't get to it but feel free to make any changes you'd like. it pairs with the launch-refinements branch of data-sources-app and dev branch of pdap.io. i won't be making any more changes here until further notice.

joshuagraber commented 6 months ago

Morning, @josh-chamberlain. I've added what I was hoping to here, re-wrote commit messages, and approved. Should be g2g. (FYI, I force-pushed after the rebasing to amend the commit messages, so probably need to force-pull or ort merge on your end, if you're pulling this to test locally.)

josh-chamberlain commented 6 months ago

@joshuagraber nice, LGTM!

github-actions[bot] commented 6 months ago

:tada: This PR is included in version 2.1.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: