fix: accessible colors and set up more neutrals

josh-chamberlain commented 3 months ago

Fixes

fixes https://github.com/Police-Data-Accessibility-Project/design-system/issues/92

Description

I've been playing with these colors and being indecisive, so I figured it was time to just submit a small PR that fixes the accessibility and play with things later.

defines 50–950 values for brand gold and wine where 500 is the original hex value
- gold's default is 600, putting it >3 accessibility-wise
- wine's default is 500, the original hex value
- 50 and 950 are not pure black or white, just close
adds goldneutral and wineneutral to the playground, but nothing is using them yet
- 50 and 950 are not pure black or white, just close
- fully swapping neutral with goldneutral or wineneutral in the config often looks very nice, but can be weird
moves blue out of the brand section out of pure pedantry (it's not a brand color)

josh-chamberlain commented 3 months ago

@joshuagraber it may be bad form to add all those neutral variants we aren't using yet, LMK and I will stash them somewhere. I do want to incorporate this soon, but I want that exercise to stop slowing down the gold accessibility thing

joshuagraber commented 3 months ago

@josh-chamberlain I don't think it's bad form. This looks good, and it'll be nice to have the full range of options available.

Do you think we can merge this to beta? Or do you need it more urgently in main?

gitguardian[bot] commented 3 months ago

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [9480360](https://dashboard.gitguardian.com/workspace/349891/incidents/9480360?occurrence=151521710) | Triggered | Generic Password | 5db616b3b05103dedc9cc06d65a28ba488b8bd31 | src/components/Form/form.spec.ts | [View secret](https://github.com/Police-Data-Accessibility-Project/design-system/commit/5db616b3b05103dedc9cc06d65a28ba488b8bd31#diff-481898299d8ace39333602399315f8ec5f02f2e9730e12bc61d030106393dfd0L202) |

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_password#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

github-actions[bot] commented 3 months ago

:tada: This PR is included in version 3.0.0-beta.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 months ago

:tada: This PR is included in version 3.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

Police-Data-Accessibility-Project / design-system