Closed benpolinsky closed 10 months ago
thanks, @benpolinsky ! I'm going to pass this to @mbodeantor to review and merge—the timing on the rest of our Vue work might mean this needs to wait (or merge ahead of) the other stuff going on. We'll keep in touch.
thanks, @benpolinsky ! I'm going to pass this to @mbodeantor to review and merge—the timing on the rest of our Vue work might mean this needs to wait (or merge ahead of) the other stuff going on. We'll keep in touch.
Great. No problem if anything needs to be adjusted to fit into what you have planned.
Convert pdap.io to Vue.js site.
Each static
*.html
page's unique content now resides insrc/views
. Repeatable sections of the site have been extracted as components tosrc/components
. Most external scripts (Google Analytics, Font Awesome, etc...) reside in the mainindex.html
file at the root of the repo. Thesitemap.xml
androbots.txt
files have been moved to/public
so they are bundled appropriately for production builds.Usage of assets from
pdap-design-system
is through standard node package management, i.e.pnpm install
. When building for production, the scripts/assets from this package will be bundled along with the app - there should be nonode_modules
orpackage-*
files residing on the production server.Copyright is dynamically generated in the footer.
I am not sure how you are deploying the application, but you should now deploy the
dist
directory after building the site for production. This could be automated using GitHub Actions, most likely. You also may have to adjust your web server configuration so URLs are forwarded to Vue's router. If you let me know which web server is used (nginx
for instance) I can advise.Lastly, I've deployed a preview to Vercel: https://pdap-quu4kcobv-benjaminpolinsky.vercel.app/