Police-Data-Accessibility-Project / pdap.io

Static HTML front page
https://pdap.io
MIT License
1 stars 3 forks source link

Deploy vue version of site #141

Closed josh-chamberlain closed 12 months ago

josh-chamberlain commented 1 year ago

Context

I merged #134, then did some clumsy reverting and stuff, and we are now in a state where dev is at the state of #134.

This PR

josh-chamberlain commented 1 year ago

@joshuagraber can we work on this next week? I linked to an attempted deployment above, I think we're missing a run command but not sure what it would be. I invited you to Digital Ocean, so we should be able to poke around there. Please excuse the chaotic commit history 😬

joshuagraber commented 12 months ago

@joshuagraber can we work on this next week? I linked to an attempted deployment above, I think we're missing a run command but not sure what it would be. I invited you to Digital Ocean, so we should be able to poke around there. Please excuse the chaotic commit history 😬

@josh-chamberlain Yes, very sorry I missed your comment until now. I saw the DigitalOcean invite and will look into this tomorrow.

mbodeantor commented 12 months ago

@josh-chamberlain All looks good to me, except the "Data Sources" link under "Directory of Data Sources" is broken.

josh-chamberlain commented 12 months ago

Actually, we're seeing the same issue here as https://github.com/Police-Data-Accessibility-Project/data-sources-app/issues/81. i.e. I can click around the website fine, but if I try to navigate directly to any page (https://pdap.dev/donate, /jobs, etc) it doesn't work.

josh-chamberlain commented 12 months ago

Attempted to fix by updating router.js (there wasn't a variable set, but i think it was likely defaulting to / anyway or nothing would have worked)

Successfully fixed by reading DO docs about custom pages, and added a "custom catchall page"

Screen Shot 2023-11-01 at 3 49 27 PM
josh-chamberlain commented 12 months ago

@benpolinsky FYI, this is finally done! thanks again for your help

benpolinsky commented 11 months ago

@benpolinsky FYI, this is finally done! thanks again for your help

Excellent! No problem.