Police-Data-Accessibility-Project / scrapers

Code relating to scraping public police data.
https://pdap.io
GNU General Public License v3.0
160 stars 37 forks source link

Audit platform-dependent aspects of scrapers #249

Open eddie-m-m opened 3 weeks ago

eddie-m-m commented 3 weeks ago

Contributions to scrapers have potentially platform-dependent aspects:

A prominent case of this are pathnames for files and folders in string literals/templates, where the following are used:

Assumptions are made in using either of these in a given scraper, and these assumptions can impact functionality (e.g. if \ for windows is used in file creation, a *nix user may not have that file created properly on their local system when they run it).

A general audit should be done that:

josh-chamberlain commented 2 weeks ago

This is a good idea! There's a template file for scrapers, and a general README, so we can establish best practices even if we don't edit individual scrapers.