Contributions to scrapers have potentially platform-dependent aspects:
A prominent case of this are pathnames for files and folders in string literals/templates, where the following are used:
/ for *nix (linux, macos, etc.) systems ('home/myfavoriterepo/morework')
\ for windows. ('home\myfavoriterepo\morework')
Assumptions are made in using either of these in a given scraper, and these assumptions can impact functionality (e.g. if \ for windows is used in file creation, a *nix user may not have that file created properly on their local system when they run it).
A general audit should be done that:
determines each scraper's pathname conventions (and any other platform-dependent aspects)
updates respective README to reflect the scraper's platform assumptions
(possibly) recommends a best practice for all submissions going forward
This is a good idea! There's a template file for scrapers, and a general README, so we can establish best practices even if we don't edit individual scrapers.
Contributions to
scrapers
have potentially platform-dependent aspects:A prominent case of this are pathnames for files and folders in string literals/templates, where the following are used:
/
for *nix (linux, macos, etc.) systems ('home/myfavoriterepo/morework')\
for windows. ('home\myfavoriterepo\morework')Assumptions are made in using either of these in a given scraper, and these assumptions can impact functionality (e.g. if
\
for windows is used in file creation, a *nix user may not have that file created properly on their local system when they run it).A general audit should be done that: