Police-Data-Accessibility-Project / scrapers

Code relating to scraping public police data.
https://pdap.io
GNU General Public License v3.0
157 stars 35 forks source link

approval language #48

Closed josh-chamberlain closed 3 years ago

josh-chamberlain commented 3 years ago

Approving scrapers

We require that scrapers be reviewed to meet our legal guidelines. Checking that scrapers comply with our legal requirements is top priority. Approve working legal scrapers.

  1. Review the scraper for legal risk. This is the most important approval criteria.
  2. Does the sample data look sane and accurate? If so, approve it!
  3. Make a comment if you have style suggestions. Better, share your skills by making a commit to their branch!
jlintag commented 3 years ago

Legality is what we're concerned with the most, less so maintainability as @mcsaucy previously mentioned. As far as data accuracy, that's something I'm hoping a downstream process will take care of vs verifying it in a code review