search

PolicyEngine / microdf

Analysis tools for working with survey microdata as DataFrames.
http://pslmodels.github.io/microdf
MIT License
12 stars 10 forks source link

Deprecate add_weighted_quantiles #185

Open MaxGhenis opened 3 years ago

MaxGhenis commented 3 years ago

It doesn't work with MicroDataFrames (weights by the weight squared if the weight column is in the DataFrame):

https://github.com/PSLmodels/microdf/blob/995a0c703af8bcc84809915df155336d9473d043/microdf/weighted.py#L155

It also sorts the data which can create issues, and it creates tons of columns when usually a user just wants one at a time. These could be overcome but I think it'd be better to invest in MicroDataFrame.rank and MicroSeries.rank (#187).