I think we should adopt a standard for OpenFisca programming to use only one of these patterns. Since we call these as a function, I'd suggest any_ and all_, which more closely resembles numpy and Python versions than and_ or or_.
That said, I'm indifferent on keeping or_ and and_ around. Python and numpy offer all four in some way, so maybe we could offer a warning that any_ and all_ are the standards and we suggest those instead, rather than breaking code? Open to suggestions here.
any_
is currently an alias foror_
, but we don't have a parallel alias forall_
toand_
:https://github.com/PolicyEngine/openfisca-tools/blob/e2bc593b29f670f302f2c64b892a3df60b7cc30d/openfisca_tools/model_api.py#L177-L179
I think we should adopt a standard for OpenFisca programming to use only one of these patterns. Since we call these as a function, I'd suggest
any_
andall_
, which more closely resembles numpy and Python versions thanand_
oror_
.That said, I'm indifferent on keeping
or_
andand_
around. Python and numpy offer all four in some way, so maybe we could offer a warning thatany_
andall_
are the standards and we suggest those instead, rather than breaking code? Open to suggestions here.