PolicyEngine / policyengine-api

PolicyEngine's REST API for computing policy impacts.

GNU Affero General Public License v3.0

7 stars 20 forks source link

CI tests failing #1423

Closed MaxGhenis closed 2 months ago

MaxGhenis commented 2 months ago

1415 was the latest PR to pass CI

@nikhilwoodruff merged #1416 despite it failing CI, and now all other updates are also failing, e.g. #1422

nikhilwoodruff commented 2 months ago

My bad- not sure what happened there. Taking a look now

anth-volk commented 2 months ago

Is this closable? Looks like the issue was that #1423 uses an old table schema, whereas the associated tests didn't? Or perhaps I'm wrong.

MaxGhenis commented 2 months ago

It is not closable - https://github.com/PolicyEngine/policyengine-api/pull/1429 CI tests are also failing for instance

anth-volk commented 2 months ago

I believe this should be fixed with #1426

MaxGhenis commented 2 months ago

I just re-ran a CI job for updating policyengine-us, now that we've merged #1426, but it's still failing.

anth-volk commented 2 months ago

Will look into it

anth-volk commented 2 months ago

The problem appears that the old CI runs are using now-deprecated table schemas, so when the tests run against the updated table structures, but utilizing the old schemas, the tests fail, despite the fact that the live code works properly. Would it be possible to test pushing 0.743.1, which was updated after the table updates, and seeing if that works?

MaxGhenis commented 2 months ago

1435, which updated policyengine-us to 0.743.1, was mergeable. Closing.