PolicyEngine / policyengine-api

PolicyEngine's REST API for computing policy impacts.
GNU Affero General Public License v3.0
7 stars 20 forks source link

Update Python version on GCP to 3.10 #1437

Closed MaxGhenis closed 2 weeks ago

MaxGhenis commented 2 months ago

Does this mean we're on Python 3.9?

https://github.com/PolicyEngine/policyengine-api/blob/7ef8b57762fbd26f5348724d6d595034629cb6cb/gcp/policyengine_api/start.sh#L6

https://github.com/PolicyEngine/policyengine-api/blob/7ef8b57762fbd26f5348724d6d595034629cb6cb/gcp/Dockerfile#L4

The latest is 3.12, and 3.11 in particular claims to be 10-60% faster than 3.10. GCP supports up to 3.12.

anth-volk commented 2 months ago

I believe you're right, we'd be on 3.9. When we last upgraded from 3.8, I remember it taking some times, as various country packages were fixed on certain versions. Are you aware of any such situation at the moment?

MaxGhenis commented 2 months ago

Possibly, might require -core updates.

MaxGhenis commented 1 month ago

Upgrading from 3.9 to 3.10 may also address this warning:

/usr/local/lib/python3.9/site-packages/rq/job.py:990: DeprecationWarning: Pipeline.hmset() is deprecated. Use Pipeline.hset() instead.

This is due to us using 3.9 in workflows.

anth-volk commented 2 weeks ago

Update on this: install doesn't seem to be an issue once I pinned a dependency version, but I'm having difficulty getting the worker to actually run. I'll continue trying