search

PolicyEngine / policyengine-app

PolicyEngine's free web app for computing the impact of public policy.
GNU Affero General Public License v3.0
37 stars 101 forks source link

Text on Income Inequality Impact page is incorrect #1050

Closed anth-volk closed 9 months ago

anth-volk commented 9 months ago

The text at the bottom in this image contains what appears to be a code separator that is rendering as text:

Screen Shot 2023-12-28 at 12 21 13 PM
gautamjuyal commented 9 months ago

Can you point out exactly which part is it? I would like to work on the issue.

anth-volk commented 9 months ago

We'd love your contribution! To contribute, please fork this repo, then open a PR from it to this one.

And it's the / in the text beginning with "The chart above"

gautamjuyal commented 9 months ago

I just checked the jsx file for the page, and found the \ is a part of the description text itself and not the code. Might be a typo. Can you confirm?

Screenshot (363)

anth-volk commented 9 months ago

Precisely, this is a typo

cullantd commented 9 months ago

Hi @anth-volk, I submitted this PR in response to the issue you raised.

MaxGhenis commented 9 months ago

Thanks @cullantd! Closing as you fixed this in #1055. Please link the PR to the issue next time: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

For future reference, maintainers including @anth-volk and myself watch the repo, so no need to comment to grab our attention or mention the PRs (linking suffices). Appreciate your contributions!