search

PolicyEngine / policyengine-app

PolicyEngine's free web app for computing the impact of public policy.
GNU Affero General Public License v3.0
36 stars 92 forks source link

CTC links are broken #1258

Open nikhilwoodruff opened 5 months ago

nikhilwoodruff commented 5 months ago

https://policyengine.org/us/research/wyden-smith-ctc

This policy exists, but the link in the blog post fails

MaxGhenis commented 5 months ago

I think this is because we renamed one of the parameters

anth-volk commented 5 months ago

Checking via the console - yeah, appears "ctc_expansion" no longer exists.

I think part of this issue emerges because back in September, we dealt with situations where households contained variables that no longer existed, but we didn't deal with policies that contain variables that no longer exist, perhaps partly because an absolute ton do - perhaps we also just skip over those in the back end? I'm not entirely sure, but when creating a household with a reform baseline, this of course then breaks.

anth-volk commented 5 months ago

I am curious, though, @nikhilwoodruff - were you seeing the below error message on your end when you ran into problems? Or just white screens?

Screen Shot 2024-01-23 at 7 43 10 PM
MaxGhenis commented 5 months ago

I'm getting a white screen.

Would suggest we show the impact without the nonexistent parameter and add a butterbar indicating that the reform modifies a parameter that no longer exists.

anth-volk commented 5 months ago

I actually was about to submit a new issue - these sort of parameters now white-screen for me, as well

anth-volk commented 5 months ago

I am in progress on this