search

PolicyEngine / policyengine-app

PolicyEngine's free web app for computing the impact of public policy.
GNU Affero General Public License v3.0
35 stars 89 forks source link

Not all authors are displayed properly on Research page's authors filter tab #1554

Open anth-volk opened 1 month ago

anth-volk commented 1 month ago

This is visible in the video below. When trying to filter by author, the last author to appear in the list is Donglai Xu, but there are about five authors below that one, and when a user scrolls all the way to the very bottom of the page, they can see them, but otherwise, it's impossible to apply filters with these authors.

https://github.com/PolicyEngine/policyengine-app/assets/14987227/24f6e956-42fa-43ea-8455-b90d4ee8db78

YashrajKupekar17 commented 1 month ago

I would like to solve this issue.

anth-volk commented 1 month ago

@YashrajKupekar17 I believe @NishantSatere is in progress on this. If he confirms he's not, I'd be happy to pass it over to you. In the meantime, I'll assign him to make clear to others the status of this.

NishantSatere commented 1 month ago

@anth-volk i am on it, i am opening the PR now

daemon-reconfig commented 1 month ago

is this issue still being worked on?

anth-volk commented 1 month ago

It looks like no. @daemon-reconfig, I'll assign you to it. There's some discussion around Nishant's previous work on this in the thread for #1585 that might also clarify what we're looking for. Basically, at any height, the authors filter tab should show all authors.

daemon-reconfig commented 1 month ago

sure I will try my best to complete it asap

daemon-reconfig commented 1 month ago

An update on this. I have tried fixing the height of the filter side and it works fine but I didn’t like it from a design perspective. so what I think we can add is something similar if it calculates the left height and adjusts it according to it.

anth-volk commented 1 month ago

Is there any way using just CSS properties to restrict the height of the opened menu to, basically, the bottom of the page (minus some padding and the other display properties), then make the interior of that a scroll container? I believe there's a native way within Ant Design to restrict the menu so that only one part opens at a time, as well, which could be a good way of doing things.

daemon-reconfig commented 1 month ago

I will show what I did in a few minutes

daemon-reconfig commented 3 weeks ago

can we close this?

anth-volk commented 3 weeks ago

No, if you go to the Research page and try expanding the authors, they are still hidden

daemon-reconfig commented 3 weeks ago

oh I see