PolicyEngine / policyengine-app

PolicyEngine's free web app for computing the impact of public policy.
GNU Affero General Public License v3.0
35 stars 89 forks source link

Added Martin Holmer to About Page #1612

Closed daemon-reconfig closed 1 month ago

daemon-reconfig commented 1 month ago

Description

Fixes #1575

Changes

Added Martin Holmer to About Page

Screenshots

image

anth-volk commented 1 month ago

Thanks for this, @daemon-reconfig. I should be able to get to this and your other PR end-of-day today, just have had some high-priority items to deal with first.

daemon-reconfig commented 1 month ago

thank you for helping me out as well!! @MaxGhenis thank you!

daemon-reconfig commented 1 month ago

sure I will change the positing of the image

daemon-reconfig commented 1 month ago
Screenshot 2024-04-18 at 5 17 27 PM

I just cropped the image as I wasnt able to add anything to only his image :P

daemon-reconfig commented 1 month ago

I am terribly sorry about the naming of the commits and I promise it wont happen again.

anth-volk commented 1 month ago

It's alright, no need to apologize, we all learn these things with time. This is what open source is meant for and why we work with so many volunteers new to development - to help developers learn industry practices.

daemon-reconfig commented 1 month ago

I seem unable to do it. Can you please help me with it? Mehul Sardana here is my linkedin if it’s fine you can add me on slack as well, thank you so much!

anth-volk commented 1 month ago

Sure, I'll invite you, just please remind me early next week and we can set up a time.

daemon-reconfig commented 1 month ago

thank you so much. I am grateful for your help and would frankly ask you to help me in times of need.

MaxGhenis commented 1 month ago

can we merge this?

anth-volk commented 1 month ago

We cannot, as this contains a stub of another PR that will break all of the buttons on the household side. That said, let me just push a couple commits on top to remove that code and we'll be good.