PolicyEngine / policyengine-app

PolicyEngine's free web app for computing the impact of public policy.
GNU Affero General Public License v3.0
32 stars 86 forks source link

Remove conditional disabled #1662

Closed anth-volk closed 2 weeks ago

anth-volk commented 2 weeks ago

Description

Fixes #1660.

Changes

It appears that code from a previous version of the application (see #114) purposely nudged a user to input their state by disabling the button in the VariabledEditor component until they had selected a state, then changed to be visible. Changes made probably as part of the recent auth update removed a couple of colors that this relied upon, causing the button to revert to Anki's default white.

However, it appears that there's no longer any need for the original changes, anyway. We now define a default state that is both visible to the user and the default for a user household without one that accesses the state selection page. As such, this PR re-inserts the deleted colors (just in case they're used somewhere else) and removes the code that conditionally disabled the state selection button.

Screenshots

A video testing the changes is available below. https://github.com/PolicyEngine/policyengine-app/assets/14987227/ae67f19f-d01c-4ecb-80c0-a650e2fa0ec3

Tests

N/A