search

PolicyEngine / policyengine-app

PolicyEngine's free web app for computing the impact of public policy.
GNU Affero General Public License v3.0
32 stars 86 forks source link

Remove the junk code within the `submitToMailchimp` function #1696

Closed anth-volk closed 1 week ago

anth-volk commented 2 weeks ago

I'm not sure which file it's in at the moment, but there's a large piece of commented code that executes a JSON-P request to Mailchimp. That's present elsewhere and should be removed.

Suvid-Singhal commented 2 weeks ago

Hi, I've made the required changes and created the PR #1704 Please have a look at it

anth-volk commented 1 week ago

Thanks @Suvid-Singhal, we really appreciate your contribution. I was out Friday, so didn't have the chance to look it over then, but will review today.

Suvid-Singhal commented 1 week ago

Hi @anth-volk, Could you please review the PR? All checks are passing now. Thanks

anth-volk commented 1 week ago

Hi @Suvid-Singhal, we want to say that we do appreciate your contributions. That said, we can't always immediately review due to high-priority bugs, improvements, etc. I will try to review today, but even if I can't, don't worry, your PR will be gotten to.

Suvid-Singhal commented 1 week ago

Apologies for the hurry.

anth-volk commented 1 week ago

Not at all