search

PolicyEngine / policyengine-app

PolicyEngine's free web app for computing the impact of public policy.
GNU Affero General Public License v3.0
32 stars 86 forks source link

Removed junk code within the submitToMailChimp function (Fixes #1696) #1704

Closed Suvid-Singhal closed 1 week ago

Suvid-Singhal commented 2 weeks ago

Description

Removed the junk code from the submitToMailChimp function in the file mailchimpSubscription.js This PR fixes #1696

Changes

Refactored the code to remove unwanted parts

anth-volk commented 1 week ago

Thanks for your work on this @Suvid-Singhal! Will review later today.

anth-volk commented 1 week ago

Could you run make format on this code?

Suvid-Singhal commented 1 week ago

Hi @anth-volk, I ran the specified command and modified the PR. I believe that it has fixed the formatting now. All the tests are passing now.

Suvid-Singhal commented 1 week ago

Thanks a lot @anth-volk for letting me know. This was my first contribution so I didn't know much. Once again, thanks a lot for your support.

anth-volk commented 1 week ago

Not at all, @Suvid-Singhal!