PolicyEngine / policyengine-app

PolicyEngine's free web app for computing the impact of public policy.
GNU Affero General Public License v3.0
32 stars 86 forks source link

Changes in the position of Line #1706

Closed psankhe28 closed 1 week ago

psankhe28 commented 2 weeks ago

Description

1690

Changes

Moved the "Run the code below" line from the Reproduce in Python pages so that it sits above the code editor

Screenshots

image

Tests

17/17 passed

anth-volk commented 1 week ago

Thanks for this @psankhe28. While it does look good, could you also just lower the bottom padding on the line so that it matches the amount below "Include earning variation"? Otherwise, I think it'll be good to go after that.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 18.64%. Comparing base (abfc873) to head (17bf724). Report is 103 commits behind head on master.

Files Patch % Lines
...ages/household/output/HouseholdReproducibility.jsx 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1706 +/- ## ========================================== - Coverage 20.36% 18.64% -1.73% ========================================== Files 171 167 -4 Lines 5906 6199 +293 Branches 1841 1970 +129 ========================================== - Hits 1203 1156 -47 - Misses 4586 4916 +330 - Partials 117 127 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

psankhe28 commented 1 week ago

image

New change

anth-volk commented 1 week ago

Thanks, this looks good! I'll check it out today or tomorrow.