Installed new React-Testing-Library version

PolicyEngine / policyengine-app

PolicyEngine's free web app for computing the impact of public policy.

GNU Affero General Public License v3.0

35 stars 89 forks source link

Installed new React-Testing-Library version #1715

Closed czhou578 closed 3 weeks ago

czhou578 commented 3 weeks ago

Description

Fixes #1685

Changes

Upgraded to the newest version of @testing-library/react, which is version 15.0.6. This removes all of the React.act errors when running npm run test.

Screenshots

Tests

I ran npm run test and all the tests passed.

czhou578 commented 3 weeks ago

@anth-volk, I am seeing some console log deprecated errors, mostly from antd. Should I leave these?

anth-volk commented 3 weeks ago

@czhou578 Please, but in the meantime, could you open them as an issue?

czhou578 commented 3 weeks ago

Done.

czhou578 commented 3 weeks ago

Is there anything else I need to do for this PR?

anth-volk commented 3 weeks ago

Not that I've come across, I just didn't have the chance to review yesterday, but will do so today. Thanks again.