Filtering for author

[psankhe28]

Description

Fixes #1726

Changes

I have fixed the filtering of the author

Tests

17/17 tests passed

[anth-volk]

Hard to believe that the change could be this simple. I haven't tested yet, but before I do, you have a commit in this that's part of a different issue (#1749). I'm guessing you opened this feature branch (filter) off of that branch (app-css) instead of off master. That's not a problem at all, could you just drop that commit and re-push? Otherwise, this seems like a simple review.

[anth-volk]

Also, could you add "Fixes " in front of the issue number? Thanks again.

[psankhe28]

Yes, I will do it.

[psankhe28]

Hi @psankhe28, thanks for your contribution here. Unfortunately, this still doesn't fix the problem. For example, go to http://localhost:3000/us/research, and on the left-hand side, under "Author", click "Max Ghenis". You'll notice that the first article, "PolicyEngine launches state income tax...", was written by Pavel Makarchuk. We're looking for all displayed articles to be by Max Ghenis.

It is possible that the root of the problem is more comprehensive than just something small. This may require some digging to determine the root of.

I may have missed something, I will look into it. Sorry!

[anth-volk]

That's alright @psankhe28! Appreciate the contribution.

[anth-volk]

Hi @psankhe28, sorry for the delay in getting back to you on this, I just had to do some thinking as to how to actually get this working.

I think this needs a more comprehensive overhaul, unfortunately. I was looking at the original code, and it is just very broken. Here's the technical setup I'm thinking:

• The component would have one “filters” stateful variable, a nested object comprised of three sub-objects: "topics", "locations", and "authors"
  • On load, this would pre-populate the "locations" segment with all items from the country or from the "global" tag (this works within the component currently, but doesn't properly display that they're selected)
  • This would be passed to each respective dropdown selector component
  • If empty, the component would display all options with none selected, otherwise display checks for those listed (this may require overwriting the "value" attribute of the list)
  • On click, each dropdown component would update "filters" by passing it into the setter (ideally via ES6 object spread operator)
  • Via an effect hook, on "filters" change, we would populate respective URL search params (as described in #823)
• Filtering articles
  • A new function would return whether or not an article includes a given tag or a given location or a given author - the current function seems to work incorrectly

This is quite a bit in the way of changes. If you'd like to take this on, we'd be happy to have your contribution. Alternatively, if you'd like something simpler, we can close this out and I can take it on later. Apologies for this being tougher than expected, we just didn't know how broken the existing filters were.