search

PolicyEngine / policyengine-app

PolicyEngine's free web app for computing the impact of public policy.
GNU Affero General Public License v3.0
37 stars 99 forks source link

Go to profile page if clicking profile picture #1957

Open MaxGhenis opened 1 month ago

MaxGhenis commented 1 month ago

To avoid an extra hover action. This is the more likely action than signing out.

anth-volk commented 1 month ago

Would the intended behavior be for the Sign Out button to still be on the dropdown menu? I could see issues with mobile, since mobile has no hover actions and we can't reliably test if a device is a mobile one prior to render.

anth-volk commented 1 month ago

Never mind, seems to make sense in light of #1958.

anth-volk commented 1 week ago

Okay, I may be misunderstanding here. If we were to implement a system whereby we went directly to the profile via the profile picture, we'd lose the sign out button, and this actually would lose some similarity to GitHub (clicking on the picture on GitHub only brings up the options menu). Is this the desired behavior?