search

PolicyEngine / policyengine-app

PolicyEngine's free web app for computing the impact of public policy.
GNU Affero General Public License v3.0
41 stars 109 forks source link

Re-enable cliff impacts #2211

Closed anth-volk closed 6 days ago

anth-volk commented 1 week ago

Description

Fixes #1843. To not crash, this requires the merging of https://github.com/PolicyEngine/policyengine-api/pull/1982; to correctly calculate UK results, https://github.com/PolicyEngine/policyengine-uk/pull/997 must also be merged. This PR will remain in draft until the merging of the relevant API changes and until I can capture some screenshots.

Changes

Re-enables cliff impacts. Also removes a hanging semicolon that created a floating semicolon on the cliff impacts output page. Most of this code merely un-comments code that was previously commented out as a result of https://github.com/PolicyEngine/policyengine-app/pull/1099.

Screenshots

Screen Shot 2024-11-19 at 1 09 56 AM Screen Shot 2024-11-19 at 1 11 49 AM

Tests

N/A

anth-volk commented 6 days ago

Good to go now

MaxGhenis commented 6 days ago

What does it say the baseline cliff rate and gap are, by CPS and ECPS?

anth-volk commented 6 days ago

At the moment, we don't actually permit the running of baseline sims, and thus I cannot run the cliff impacts, either. Is there another policy we can use?

Alternatively: should we be enabling baseline runs?

MaxGhenis commented 6 days ago

Just hover over the bar chart

anth-volk commented 6 days ago

Here are screenshots of the requested four outputs:

Screen Shot 2024-11-19 at 11 21 10 PM Screen Shot 2024-11-19 at 11 21 18 PM Screen Shot 2024-11-19 at 11 33 37 PM Screen Shot 2024-11-19 at 11 33 44 PM
anth-volk commented 6 days ago

This is using the MTR-based definition and a delta of $1,000

MaxGhenis commented 6 days ago

Thanks. For posterity (data for 2024):

Dataset Cliff rate Cliff gap
CPS 3.5% $51.3bn
ECPS 4.3% $70.3bn