Broken MTR chart

[MaxGhenis]

https://policyengine.org/us/household?focus=householdOutput.mtr&household=30669

Also happened yesterday with a different reform

[MaxGhenis]

@lswainemoore and I also just hit some MTR bugs when evaluating the impact of the CalEITC (using a repealed custom baseline): https://policyengine.org/us/household?focus=householdOutput.mtr&household=30574&region=us&timePeriod=2023&baseline=6416&reform=2

And https://policyengine.org/us/household?focus=householdOutput.mtr&household=30688&region=us&timePeriod=2023&baseline=6416&reform=2

[sumitshinde-84]

@MaxGhenis I would be interested in working on this task. Could you please assign it to me and provide additional details about the issue so that I can effectively solve it?

[MaxGhenis]

Thank you @sumitshinde-84! Though I suspect this is going to be a complex bug that also involves the backend. @nikhilwoodruff could you suggest ways Sumit can help, or assign yourself if if it needs to be you?

[nikhilwoodruff]

Sure- I think we just need to figure out what the root cause is. I'd suggest trying:

• DevTools in the browser to look at whether the marginal tax rates API request got a 500 error
• If the error is client-side (no 500), then console.log-ing values from the MTR component to see what looks wrong first
• If the error is server-side (500), then using the 'reproduce in python' snippet as a starter to see what the model error is

[sumitshinde-84]

Thank you so much @MaxGhenis @nikhilwoodruff I would like to give it try .

[sumitshinde-84]

@MaxGhenis Hey there! I wanted to reach out and kindly request your valuable review on the pull request. Your expertise and feedback mean a lot to me, and I truly appreciate your time and consideration. Thank you so much!

[MaxGhenis]

Here's another similar instance: Creating a single parent of one 4yo child in California, with $24k rent, $12k childcare, and $600 broadband, shows functional net income and MTR charts when first making them, but then refreshing the page makes it break.

https://policyengine.org/us/household?focus=householdOutput.mtr&household=30975

https://www.loom.com/share/a16f95bebe3847bf9715c81b5049aeeb

I thought this might have been because I modified the household later to create others, so I just made another without further modifying it, identical except one cent different rent, and it happened again: https://policyengine.org/us/household?focus=householdOutput.earnings&household=31007

And once more going through each variable more slowly to ensure I wasn't adjusting rent/childcare/broadband too quickly and creating some sort of race condition, but still hit it: https://policyengine.org/us/household?focus=householdOutput.earnings&household=31011

[nikhilwoodruff]

OK now fixed, so closing.