search

PolicyEngine / policyengine-app

PolicyEngine's free web app for computing the impact of public policy.
GNU Affero General Public License v3.0
35 stars 89 forks source link

No logo on household charts #550

Closed MaxGhenis closed 10 months ago

MaxGhenis commented 1 year ago

Net income and MTRs, baseline and baseline+reform

image image image image
SamantaTarun commented 11 months ago

I'd like to work on it

SamantaTarun commented 11 months ago

which icon and where should i add that icon to the chart?

MaxGhenis commented 11 months ago

Same as on all other charts

SamantaTarun commented 11 months ago

@MaxGhenis I am facing some issues from my side. could you please send me the page url of the above charts?

MaxGhenis commented 11 months ago

Here's an example of a chart with the logo: https://policyengine.org/us/policy?focus=policyOutput.netIncome&region=us&timePeriod=2023&baseline=2&reform=14512

image
SamantaTarun commented 11 months ago

Here's an example of a chart with the logo: https://policyengine.org/us/policy?focus=policyOutput.netIncome&region=us&timePeriod=2023&baseline=2&reform=14512

image

No, it's fine I saw this logo. The problem is that when I am searching for the above charts in code, I can see that those charts have chartLogo included. That's why i am asking for the url so that I can confirm after making changes.

MaxGhenis commented 11 months ago

You can test locally with npm start. Please look through the code to find the chartLogo info.

MaxGhenis commented 10 months ago

Removing your assignment @tarunsamanta2k20 in case someone else can do it. Please open a draft PR and link the issue if you're on it.

SamantaTarun commented 10 months ago

Removing your assignment @tarunsamanta2k20 in case someone else can do it. Please open a draft PR and link the issue if you're on it.

Facing some issues in my side. Trying to resolce issues.

SamantaTarun commented 10 months ago

@MaxGhenis are you sure that this issue has not been resolved yet? Please confirm once over here.

MaxGhenis commented 10 months ago

It has not been resolved.

image

https://policyengine.org/us/household?focus=householdOutput.earnings&household=32041

SamantaTarun commented 10 months ago

@MaxGhenis Okay, then let me do it.

MaxGhenis commented 10 months ago

As I said, please file a draft PR if you have work on it. But given you requested to be assigned a month ago and didn't work on it, I'd like to give others the opportunity. It's a reasonably high priority and low expected effort. Thanks for your understanding.

SamantaTarun commented 10 months ago

@MaxGhenis I was facing some issues.