Calculator child input and marriage input buttons are rounded

[anth-volk]

They should ideally be squared like all other buttons on the site

[MaxGhenis]

This is true of all categoricals right?

I think we should go with a standard like the antd radio buttons instead, to make it more obvious that it's a choice: https://ant.design/components/radio

Specifically this is closest:

optionType="button"
buttonStyle="solid"

[anth-volk]

Good point, could improve accessibility as well.

And I suppose it is true for all categoricals, but since link buttons are squared, I wonder if maybe we should use an antd standard, but squared? Or minimally rounded, as in the image you sent, at the least.

On Nov 28, 2023, at 20:20, Max Ghenis @.***> wrote:

 This is true of all categoricals right?

I think we should go with a standard like the antd radio buttons instead, to make it more obvious that it's a choice: https://ant.design/components/radio

Specifically this is closest: image.png (view on web)

optionType="button" buttonStyle="solid" — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

[MaxGhenis]

This is a bigger conversation but I'm partial to going with a design standard like Ant for all buttons. I think this would improve usability, accessibility, and maintainability. For example the button color swiping across makes it feel sluggish, especially when moving a cursor across multiple buttons. I think there are good reasons for the kinds of choices designers at Ant and elsewhere adopt when creating standards. We're innovating on enough fronts already ;)

[maurobusso]

I personally think in this situation with a big squared button below, two rounded one on the top would make the page look stylistically a bit messy. But this is just my opinion. :)

[daemon-reconfig]

can I take this issue?

[anth-volk]

@daemon-reconfig Sure. Just a few things to note:

• As described in the README, please open a PR off of a fork, not the cloned repo
• When opening the PR, please add "Fixes #issue number" in the description
• This should be redone as an Ant Design radio component, as described by Max in the description above. That said, we'd ideally like the background color of a selected item to be "BLUE_PRIMARY", available as a constant in src/redesign/style/colors. If this can't be implemented, it may be better to wait until we upgrade to Ant Design v5.

[daemon-reconfig]

sure thanks for letting me know. I am terribly sorry for this late reply

[daemon-reconfig]

is this what we were looking for?

[anth-volk]

Not at all a problem. We're looking for something similar, except it should be an Ant Design radio component, as described by Max above, with completely squared off sides, i.e., a specified border radius of 0.

[daemon-reconfig]

i did make the border radius 0 but it looked weird. although if you want to i shall do the same. i am sorry if i wasn’t able to understand anything.

[anth-volk]

That's alright, could you just share a photo so we can see how it looks?

[daemon-reconfig]

i will send them to you asap

[daemon-reconfig]

this is how it looked

[anth-volk]

I see. Could you use the parameter that Max mentioned, i.e., optionType="button" and send again?

[daemon-reconfig]

here

[anth-volk]

There's specifically a component where the individual items are merged together in Ant Design. The docs on this are at https://4x.ant.design/components/radio/#header. This is what Max is referring to.

[daemon-reconfig]

hmm so I need to change the whole RadioButton.jsx and add antd buttons right? or I can recreate something similar to the above example

[anth-volk]

Ah, this isn't already an Ant Design component? In that case, yes, we would be looking to replace it with antd, as we're trying to standardize against that library.

[daemon-reconfig]

sure will try, also this wasn't an ant design component

[daemon-reconfig]

is this it?

[daemon-reconfig]

changed into antd buttons

[anth-volk]

Thank you very much. One last thing - could you change the text color on the selected item to be easier to read, perhaps by using the WHITE color that we provide in the same styles files that you used for the color? And after that, is this ready for review?

[daemon-reconfig]

Did change the colors of it and yes it is ready for review should i open a PR

[anth-volk]

Sure, please feel free. In it, it'd be great if you could provide a screenshot of the final component, as well. Thanks so much, @daemon-reconfig.

[daemon-reconfig]

sure will

[daemon-reconfig]

[daemon-reconfig]

if its fine i will open a pr

[daemon-reconfig]

can we close this issue?

[anth-volk]

Yes, thank you