search

PolicyEngine / policyengine-app

PolicyEngine's free web app for computing the impact of public policy.
GNU Affero General Public License v3.0
37 stars 99 forks source link

Add visual regression tests for frequently visited configurations #989

Open abhcs opened 8 months ago

abhcs commented 8 months ago

Description

I have encountered a few regressions lately, e.g., #987 and #955. Errors such as #987 should be detected by visual regression tests. Errors such as #955 may also require some interactions with components.

Coverage

Since there are many variables and parameters, we should have two versions of tests: one which covers frequently used configurations and another which is more extensive in scope.

anth-volk commented 8 months ago

I would have to agree with you. That said, one issue we've consistently run into is that any app-wide visual testing via the Jest framework fails to mock the application due to its inability to use ES6 module imports and due to the fact that all of our components are .jsx files, instead of the more standard .js. If you'd be willing to look into how to get around this issue or could recommend a different platform, it would be incredibly helpful and impactful.

abhcs commented 8 months ago

I will let you know if I find something that works.