New changes break parametric reforms in US model

PolicyEngine / policyengine-core

Core microsimulation engine for PolicyEngine models. Forked from OpenFisca-Core.

GNU Affero General Public License v3.0

14 stars 19 forks source link

Closed MaxGhenis closed 9 months ago

MaxGhenis commented 9 months ago

PRs #127 and/or #128 fixed bugs that affected UK microsimulation accuracy with respect to uprating and reforms, but caused the US one to break entirely (https://github.com/PolicyEngine/policyengine-us/issues/3311).

MaxGhenis commented 9 months ago

The app and policyengine-us package are now OK.

The UK Autumn Statement benefit uprating change isn't completing, as we've pinned to a version of policyengine-core that probably didn't support that.

MaxGhenis commented 9 months ago

@nikhilwoodruff can we close this given your handling of the issue in policyengine-us?

nikhilwoodruff commented 9 months ago

Yes- just verified on the live site