Uncap nptyping

[MaxGhenis]

Currently <2:

https://github.com/PolicyEngine/policyengine-core/blob/4c67661f0e7e23d526f5bc99af91f8b54a9bd0c9/setup.py#L22

But it's now on 2.5.0: https://pypi.org/project/nptyping/

[tawandamoyo]

Hello @MaxGhenis , I have run into some difficulties.

Initially it looked like using nptyping without version constraints worked but this was due to the cached old version.

When I completely uninstalled nptyping and reinstalled dependencies with an uncapped nptyping, the tests failed with the following error:

ImportError: cannot import name 'types' from 'nptyping'

This error persists with any version of nptyping >= 2.0.0.

I'm not entirely sure but it appears that there may have been a breaking change in nptyping from version 2 onwards, that leads to an error here.

I'd really appreciate your insights on how to proceed.

Thanks

[MaxGhenis]

That link doesn't work. Can you check the nptyping release notes and other parts of the package to see how we should migrate our code?

[MaxGhenis]

I also wonder if we should just migrate to np.typing, see https://github.com/ramonhagenaars/nptyping/discussions/122

I don't think this was available when it was first integrated to openfisca/policyengine

@nikhilwoodruff wdyt?

[tawandamoyo]

That link doesn't work. Can you check the nptyping release notes and other parts of the package to see how we should migrate our code?

Alright, looking into it (and fixed the link)

[tawandamoyo]

@MaxGhenis so should I use np.typing?

[MaxGhenis]

If it provides the same functionality, np.typing will be better maintained so yes. But might be a heavier lift.